XCAssets: Add new simplified template simple-swift4
#605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately the tests fail for me locally, probably also will on the CI. Don't know what I missed, I've updated the fixtures manually (generating didn't work even when the schemes were selected). What did I miss? |
djbe
changed the title
simple-swift4simple-swift4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new template removes the need for the last call part like
.coloror.image. Also it adds a typealias for each catalog if multiple are used to prevent calls likeAsset.ColorsorAsset.Images. See also #603 for more information on the rationale.