Strings: reverted to case-sensitive sorting for keys #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grigorye
force-pushed
the
feature/Case-Sensitive-Localized-Strings-Sorting
branch
from
1b6e7c2
to
233a4b2
Compare
grigorye
changed the title
djbe
changed the title
djbe
force-pushed
the
feature/Case-Sensitive-Localized-Strings-Sorting
branch
from
233a4b2
to
cea4747
Compare
djbe
force-pushed
the
feature/Case-Sensitive-Localized-Strings-Sorting
branch
2 times, most recently
from
19ca485
to
cf4273e
Compare
djbe
force-pushed
the
feature/Case-Sensitive-Localized-Strings-Sorting
branch
from
cf4273e
to
cb0617c
Compare
Draft
djbe
force-pushed
the
feature/Case-Sensitive-Localized-Strings-Sorting
branch
from
cb0617c
to
026aa23
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Yeah this is a very well known issue with Anyway, this has little to do with SwiftGen 😅 @grigorye's original issue was with 2 keys with the same value (differing only in case). Honestly not a realistic situation, curious if anyone has a good test case for this. And if so, please try out these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #891, as well as slightly affect the performance due to no need to lowercase keys on every comparison during the sorting.