macOS Sonoma Fixes #166
Open
macOS Sonoma Fixes #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* TODO: The buttons need PlainButtonStyle() or a similiar custom style, however, that breaks the ability to click on them, SwiftUI bug?
|
Hi, Could you please revert the team ID in the Xcode project back to what it was originally? |
cryptoAlgorithm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bit of a noisy commit, sorry about that. This repo should use a formatter, SwiftFormat is a good one.
It appears to be a SwiftUI bug, however applying a
.buttonStyle()modifier, even with aPlainButtonStyle()appears to break the ability to click on any of the Server (AKA Guild) buttons -- at least on macOS 14 Sonoma. Not sure if it's functioning correctly on macOS 13 Ventura or below.In this revision I've removed the
.buttonStyle()which introduces the default style -- slightly ugly rounded rect button backgrounds to the buttons, however; it restores the functionality of these buttons in the meantime.The work for that can be summarized in the changes within the following files:
There was also a fix for the settings window, as it does not open on versions macOS 14 Sonoma and above without being opened from within a
SettingsLinkclosure.If server buttons are working as expected for older versions of macOS, I can clean these changes up and work out of a macOS 14 Sonoma branch which you can merge at some point down the line.
Thanks! I appreciate your work so far on Swiftcord, the Swift community keeps getting more interesting by the day 馃槃.