Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SynchronizedResolver property to Resolver protocol #466

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

itsthejb
Copy link

    public func assemble(container: Container) {
        container.register(FooModule.self) { resolver in
            FooModuleImplementation(resolver: resolver.synchronizedResolver)
        }
    }

Happy to discuss other options, but we will be using this as a fix for the time being

@talron10
Copy link

talron10 commented Dec 2, 2020

Did it work for you? It seems like this will create a few synchronized resolvers while there should be only one, we are considering using this solution too

@itsthejb
Copy link
Author

@talron10 Yes, it works - not crashing. But it's far from ideal, more like a workaround for now. If you have serious stability issues, it might be worth doing in the short-term, though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants