Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register race condition fix #505

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

omarzl
Copy link

@omarzl omarzl commented Dec 7, 2021

This pr looks ugly but it is not.
It adds thread safety to the register to solve a race condition.

  • I renamed SynchronizedResolver to SynchronizedContainer
  • I created the protocols _Register and Register and I moved _register and register functions from Container to them.
  • This allows me to be able to conform Register protocol in SynchronizedContainer and make it use the same NSLock object to make register calls thread safe.
  • I modified Sources/SynchronizedContainer.Arguments.erb and ran script/gencode, there is where most of the changes come from.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant