Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix carthage build #140

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

gilroykilroy
Copy link

Fix carthage build by checking in the generated Swift header file into the project. Perhaps some tweaking of search paths would solve the problem too but I could not figure that out.

@Lex-Nagtegaal
Copy link

when will this pull request be merged?

@yoichitgy
Copy link
Member

yoichitgy commented Jul 2, 2021

Thank you for making the PR😃 and sorry for taking too long to respond🙇‍♂️

I'm not sure we still see the issue when using Carthage.

@mpdifran
Copy link
Member

mpdifran commented Jul 4, 2021

Yeah I don't think this is necessary. The included ./carthage-build.sh helps get around the build issue when not using xcframeworks, and we'll add xcframework support in the next major version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants