Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(charts): re-adjust notebooks rate limits #155

Merged
merged 1 commit into from Jul 1, 2019

Conversation

lorenzo-cavazzi
Copy link
Member

We have recently raised the rate limits for requests to the notebooks service (#154) but it is occasionally reached when starting a new notebook with SwissDataScienceCenter/renku-ui#472 . Considering that SwissDataScienceCenter/renku-notebooks#177 has been merged, we can safely relax it a little bit more.

@lorenzo-cavazzi lorenzo-cavazzi requested a review from a team as a code owner July 1, 2019 13:07
Copy link
Contributor

@ableuler ableuler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we get rid of the extra rate limit for the notebooks service and just apply the general rate limit then?

@lorenzo-cavazzi
Copy link
Member Author

yes, it probably makes sense since they are not so different anymore

@lorenzo-cavazzi lorenzo-cavazzi merged commit be8022b into master Jul 1, 2019
@lorenzo-cavazzi lorenzo-cavazzi deleted the 000-readjust-rate-limits branch July 1, 2019 14:38
@lorenzo-cavazzi lorenzo-cavazzi added this to the 0.4.1 milestone Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants