Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

187 recover from autosave only when branch commit match #189

Merged

Conversation

m-alisafaee
Copy link
Contributor

The autosave branch is recovered only when its branch and commit-sha match with the those of notebook's. See #187.

This also fixes an uncaught exception which was introduced in #185.

This was tested on a repo with two branches for various scenarios.

@m-alisafaee m-alisafaee requested a review from a team as a code owner June 26, 2019 14:16
@rokroskar rokroskar merged commit 790f92c into master Jul 1, 2019
@rokroskar rokroskar deleted the 187-recover-from-autosave-only-when-branch-commit-match branch July 1, 2019 12:09
lorenzo-cavazzi added a commit to SwissDataScienceCenter/renku-ui that referenced this pull request Jul 12, 2019
add support for the autosaved branches features introduced by
SwissDataScienceCenter/renku-notebooks#189 by separating the renku/autosave branches from the
user-created branches and showing a warning to the user when starting a new JupyterLab server from a
branch/commit combination with available autosaved content

fix #507
lorenzo-cavazzi added a commit to SwissDataScienceCenter/renku-ui that referenced this pull request Jul 15, 2019
add support for the autosaved branches features introduced by
SwissDataScienceCenter/renku-notebooks#189 by separating the renku/autosave branches from the
user-created branches and showing a warning to the user when starting a new JupyterLab server from a
branch/commit combination with available autosaved content

fix #507
lorenzo-cavazzi added a commit to SwissDataScienceCenter/renku-ui that referenced this pull request Jul 15, 2019
add support for the autosaved branches features introduced by
SwissDataScienceCenter/renku-notebooks#189 by separating the renku/autosave branches from the
user-created branches and showing a warning to the user when starting a new JupyterLab server from a
branch/commit combination with available autosaved content

fix #507, closes #429
vfried pushed a commit to SwissDataScienceCenter/renku-ui that referenced this pull request Jul 19, 2019
add support for the autosaved branches features introduced by
SwissDataScienceCenter/renku-notebooks#189 by separating the renku/autosave branches from the
user-created branches and showing a warning to the user when starting a new JupyterLab server from a
branch/commit combination with available autosaved content

fix #507, closes #429
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants