Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use shortened commit-sha to check for an autosave match #190

Merged

Conversation

m-alisafaee
Copy link
Contributor

Fixes a bug in check for autosaved branch commit-sha where it was checking against the long commit-sha instead of the short one.

@m-alisafaee m-alisafaee requested a review from a team as a code owner July 3, 2019 07:10
@m-alisafaee
Copy link
Contributor Author

@rokroskar and @lorenzo-cavazzi please test this to see if you it resolves your issue. It worked for me.

@m-alisafaee m-alisafaee requested a review from a team as a code owner July 3, 2019 14:20
@lorenzo-cavazzi
Copy link
Member

It's testable in the UI form here: https://lorenzotest.dev.renku.ch
It's working for me, but there is the discussion going on here #187 and this PR is built on top of it, right? If it's not strictly related we can proceed and merge this

@m-alisafaee
Copy link
Contributor Author

Did you test with this latest commit: 2720d1f?

@lorenzo-cavazzi
Copy link
Member

right, let me update the preview and test it again

Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working fine for me now! And I absolutely love this feature!

If anyone else what to try the feature from the UI, I updated the preview here: https://lorenzotest.dev.renku.ch/

@m-alisafaee m-alisafaee self-assigned this Jul 3, 2019
@m-alisafaee
Copy link
Contributor Author

Please don't merge this until we agree upon the final solution in #187.

@rokroskar
Copy link
Member

@mohammad-sdsc if this meets the requirements we came up with last Friday, could we merge it?

@m-alisafaee m-alisafaee merged commit e1001b5 into master Jul 9, 2019
@m-alisafaee
Copy link
Contributor Author

Done!

@rokroskar rokroskar deleted the 187-recover-from-autosave-only-when-branch-commit-match branch July 9, 2019 08:19
@m-alisafaee
Copy link
Contributor Author

Closes #187

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants