Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(client): update UI routing #3009

Merged
merged 15 commits into from
Feb 6, 2024
Merged

refactor(client): update UI routing #3009

merged 15 commits into from
Feb 6, 2024

Conversation

leafty
Copy link
Member

@leafty leafty commented Jan 31, 2024 •
edited

See #2605.

First part of refactoring UI routing:

  • Refactor routing to remove the use of the render in favor of a child component
  • Refactored some components to remove one level of prop drilling and replace the propagation of location and history to use the hooks from react-router

/deploy renku=release-0.47.1

@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-3009.dev.renku.ch

@leafty leafty marked this pull request as ready for review February 5, 2024 14:01
@leafty leafty requested a review from a team as a code owner February 5, 2024 14:01
@lorenzo-cavazzi lorenzo-cavazzi linked an issue Feb 5, 2024 that may be closed by this pull request
Refactor UI routing #2605
Open
@lorenzo-cavazzi lorenzo-cavazzi self-assigned this Feb 6, 2024
lorenzo-cavazzi
lorenzo-cavazzi approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thank for going through this 🙏

@leafty leafty merged commit a814416 into main Feb 6, 2024
16 of 17 checks passed
@leafty leafty deleted the leafty/2605-refactor-routing branch February 6, 2024 20:45
@RenkuBot
Copy link
Contributor

RenkuBot commented Feb 6, 2024

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorenzo-cavazzi lorenzo-cavazzi lorenzo-cavazzi approved these changes

Assignees

@lorenzo-cavazzi lorenzo-cavazzi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor UI routing
3 participants
@leafty @RenkuBot @lorenzo-cavazzi