Update Notebooks components #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorenzo-cavazzi
force-pushed
the
494-notebook-status
branch
from
d85b6bf
to
57df017
Compare
ciyer
requested changes
Jul 2, 2019
lorenzo-cavazzi
force-pushed
the
494-notebook-status
branch
from
57df017
to
1933925
Compare
|
I have updated the text in the 2 messages and aligned all |
The servers endpoint used for notebooks interaction has slightly changed and the server status information are different. This refactor handles the new information properly and remove duplicate codes from Project pages BREAKING CHANGE: different status indication for notebook pages, according to renku-notebooks#177 fix #494
lorenzo-cavazzi
force-pushed
the
494-notebook-status
branch
from
1933925
to
00af877
Compare
|
I realized I forgot to move the project id filtering logic from "Projects" pages to the "notebook-servers" API. Now it has been updated and re-deployed to https://lorenzotest.dev.renku.ch This logic could be simplified in the future using the new notebook service API from SwissDataScienceCenter/renku-notebooks#188 |
ciyer
approved these changes
Jul 3, 2019
lorenzo-cavazzi
added a commit
that referenced
this pull request
Jul 10, 2019
#498 introduced a bug in Notebook.state since the polling actions are never interrupted when needed -- e.g. when the query to the servers endpoint is skipped or the list of servers is still updating
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the UI adaptation to handle the API responses from SwissDataScienceCenter/renku-notebooks#177 (requires also SwissDataScienceCenter/renku-notebooks#187)
A preview is available here: https://lorenzotest.dev.renku.ch
At the moment we have lost the distinction between "starting" and "stopping" servers, we only mark them as "pending". This may be acceptable, but the UI shows that after the stop API is invoked, the server will still be considered "ready" for a while.
An idea to improve this could be using an extra annotation to save in the pod the information that the stop command has been invoked by the user, then returning it in the
/serversendpoint in the status.