Skip to content
This repository has been archived by the owner on Sep 21, 2023. It is now read-only.

windows 10 service disabler.ps1 #398

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

windows 10 service disabler.ps1 #398

wants to merge 9 commits into from

Conversation

Brandonbr1
Copy link

@Brandonbr1 Brandonbr1 commented Jun 3, 2021 •
edited

this will be the last version of the script the last one

old pull requests:#397

@Brandonbr1
windows 10 service disabler.ps1
d1535db 
this will be the last version of the script the last one the pervious ones i forgot to put the .ps1 extention at the end lol😂 anyways it disables useless windows 10 services.
This was referenced Jun 3, 2021
Closed
Closed
@Brandonbr1
Copy link
Author

this is the latest version of my script

IanHollow
IanHollow suggested changes Jun 3, 2021
View reviewed changes
Copy link

@IanHollow IanHollow left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changes overall need some minor tweaks. It all comes down to preferences though.

Individual Scripts/windows 10 service disabler.ps1 Outdated Show resolved Hide resolved
Individual Scripts/windows 10 service disabler.ps1 Outdated Show resolved Hide resolved
Individual Scripts/windows 10 service disabler.ps1 Outdated Show resolved Hide resolved
@IanHollow IanHollow mentioned this pull request Jun 3, 2021
Closed
Brandonbr1 and others added 4 commits June 4, 2021 18:22
Sycnex
Sycnex suggested changes Jun 27, 2021
View reviewed changes
Copy link
Owner

@Sycnex Sycnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure what you're trying to do with lines 127-141. It looks like some services are being looked to see if they're stopped, and if so, then stop them? Are you trying to instead see if they're enabled and then stop them?

Couldn't you also just add the HyperV services as well as the HP services into the original array starting on line 5?

These are some suggestions.

@Brandonbr1
Copy link
Author

I'm unsure what you're trying to do with lines 127-141. It looks like some services are being looked to see if they're stopped, and if so, then stop them? Are you trying to instead see if they're enabled and then stop them?

Couldn't you also just add the HyperV services as well as the HP services into the original array starting on line 5?

These are some suggestions.

uh i did all the changes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Sycnex Sycnex Sycnex requested changes

@IanHollow IanHollow IanHollow requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Brandonbr1 @Sycnex @IanHollow