[RFC] Using tabs for channel pricing #11529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lchrusciel
reviewed
May 29, 2020
src/Sylius/Bundle/AdminBundle/Resources/views/Product/Tab/_details.html.twig
Show resolved
Hide resolved
mamazu
force-pushed
the
prices
branch
3 times, most recently
from
abba513
to
2ae8bce
Compare
|
Hey Max, can you rebase once again? Tests are probably failing due to bc break at Symfony end (see #11542) |
lchrusciel
approved these changes
Jun 2, 2020
lchrusciel
reviewed
Jun 2, 2020
src/Sylius/Behat/Context/Ui/Admin/ManagingProductVariantsContext.php
Outdated
Show resolved
Hide resolved
src/Sylius/Behat/Context/Ui/Admin/ManagingProductVariantsContext.php
Outdated
Show resolved
Hide resolved
mamazu
force-pushed
the
prices
branch
4 times, most recently
from
e2429ae
to
918e7f1
Compare
…xt.php Co-authored-by: Łukasz Chruściel <lchrusciel@gmail.com>
|
I rebased the feature on a working master. So if it breaks now this should be my fault. |
lchrusciel
approved these changes
Jun 15, 2020
|
One thing I am not sure about is the message about the product being not active in this channel. Which would in turn also solve the issue #11559 . |
lchrusciel
approved these changes
Jun 16, 2020
|
Thanks, @mamazu! 🎉 |
|
According to your doubts, let's iterate over it on the master. It already looks much better :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal
Channel prices in a simple product get displayed on the product page under the list of channels. So I propose that they will be made into a tabbed view so that they are more easy to manage. If you have a lot of channels (where the product is not active for example) you have a lot of values to scroll through.
Before
After