Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Admin] Footer #16210

Open
wants to merge 4 commits into
base: 2.0
Choose a base branch
from
Open

[Admin] Footer #16210

wants to merge 4 commits into from
+63 −0

Conversation

Rafikooo
Copy link
Contributor

@Rafikooo Rafikooo commented May 2, 2024 •
edited

Q A
Branch? 2.0
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
License MIT
image

@Rafikooo Rafikooo requested review from a team as code owners May 2, 2024 16:48
@probot-autolabeler probot-autolabeler bot added the Admin AdminBundle related issues and PRs. label May 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024 •
edited

Bunnyshell Preview Environment deployed

It will be automatically stopped in 4 hours.

Use the command /bns:start to start it if it's stopped.

Component Endpoints
mailhog https://mailhog-7e3uxf.bunnyenv.com/
php https://store-7e3uxf.bunnyenv.com/

Available commands:

  • /bns:stop to stop the environment
  • /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

@Rafikooo Rafikooo force-pushed the footer branch 2 times, most recently from 354fe48 to 92d265a Compare May 6, 2024 12:38
@GSadee GSadee changed the base branch from bootstrap-admin-panel to 2.0 May 20, 2024 09:30
@GSadee
Copy link
Member

GSadee commented May 20, 2024

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "footer" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

GSadee
GSadee reviewed May 21, 2024
View reviewed changes
src/Sylius/Bundle/AdminBundle/Resources/config/app/twig_hooks/common/create.yaml
@@ -17,6 +17,9 @@ twig_hooks:
template: '@SyliusAdmin/shared/crud/create/content/form.html.twig'
configuration:
render_rest: true
footer:
template: '@SyliusAdmin/shared/crud/common/content/footer.html.twig'
priority: -100
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will add priorities to all the hooks at the end of the work on the BAP

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a problem with the layout in the following views. I wasn't able to set the footer at the bottom without using priorities.

image image

src/Sylius/Bundle/AdminBundle/templates/shared/crud/common/content/footer.html.twig Outdated Show resolved Hide resolved
src/Sylius/Bundle/AdminBundle/templates/shared/crud/common/content/footer.html.twig Outdated Show resolved Hide resolved
src/Sylius/Bundle/AdminBundle/templates/shared/crud/common/content/footer.html.twig Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Admin AdminBundle related issues and PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Rafikooo @GSadee