Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hard dependency for ShopBillingData #16251

Open
wants to merge 5 commits into
base: 1.13
Choose a base branch
from

Conversation

gewebe
Copy link

@gewebe gewebe commented May 11, 2024

This hard dependency on the ShopBillingData class makes it extremely difficult to extend the code.

Q A
Branch? 1.13, 1.14
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

@gewebe gewebe requested review from a team as code owners May 11, 2024 20:40
Copy link

github-actions bot commented May 11, 2024

Bunnyshell Preview Environment deployment failed

Check https://github.com/Sylius/Sylius/actions/runs/9064418438 for details.

Available commands:

  • /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant