Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make classes final #316

Open
wants to merge 5 commits into
base: 2.x
Choose a base branch
from
Open

make classes final #316

wants to merge 5 commits into from

Conversation

jrushlow
Copy link
Collaborator

@jrushlow jrushlow commented Apr 26, 2024 •
edited

  • replaces the annotated @final with PHP final keyword
  • update tests that mock these classes
  • document changes in the upgrade log (I'm sure someone out there is using these in userland) 馃憖
  • flesh out the new interfaces

@jrushlow jrushlow added the Minor Minor Enhancement label Apr 26, 2024
@jrushlow jrushlow added this to the 2.x - Pre-release milestone Apr 26, 2024
@jrushlow jrushlow mentioned this pull request Apr 26, 2024
Open
19 tasks
@jrushlow jrushlow added Feature New Feature and removed Minor Minor Enhancement labels May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Feature New Feature
Projects
None yet
Milestone
2.x - Pre-release
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jrushlow