Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/more flexible as provider #1574

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

l-1squared
Copy link
Collaborator

@l-1squared l-1squared commented Mar 27, 2024

Missing:
[x] documentation
[x] tests
[x] works for method names.
[x] check once for a real JGiven test
[x] double check using As provider for method descriptions -- getDescription uses it. If anything we're more correct now

@l-1squared l-1squared force-pushed the feature/more-flexible-as-provider branch 2 times, most recently from 20c6090 to a8cc2cd Compare April 12, 2024 13:25
@l-1squared l-1squared marked this pull request as ready for review April 15, 2024 14:31
Copy link
Collaborator

@fudler fudler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First comments, not yet finished.

docs/stages.adoc Outdated Show resolved Hide resolved
docs/stages.adoc Outdated
@@ -66,6 +67,7 @@ public MyStage some_step() {
return self();
}
----
In additon, the `@As` annotation allows declaring an `AsProvider` that handles the step name generation. A default provider can be set via in a JGiven configuration.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be set via [???] in a ...

Signed-off-by: l-1squared <30831153+l-1squared@users.noreply.github.com>
Signed-off-by: l-1squared <30831153+l-1squared@users.noreply.github.com>
Signed-off-by: l-1squared <30831153+l-1squared@users.noreply.github.com>
Signed-off-by: l-1squared <30831153+l-1squared@users.noreply.github.com>
Signed-off-by: l-1squared <30831153+l-1squared@users.noreply.github.com>
Signed-off-by: l-1squared <30831153+l-1squared@users.noreply.github.com>
Signed-off-by: l-1squared <30831153+l-1squared@users.noreply.github.com>
Signed-off-by: l-1squared <30831153+l-1squared@users.noreply.github.com>
Signed-off-by: l-1squared <30831153+l-1squared@users.noreply.github.com>
Signed-off-by: l-1squared <30831153+l-1squared@users.noreply.github.com>
@l-1squared l-1squared force-pushed the feature/more-flexible-as-provider branch from 5034d4c to 3ac595e Compare May 15, 2024 14:44
@l-1squared l-1squared requested a review from fudler June 5, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants