Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ts-jest warning when running tests #75

Closed
wants to merge 2 commits into from
Closed

Remove ts-jest warning when running tests #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3435608
Remove ts-jest warning when running tests
albertodiazdorado-tng Sep 3, 2021
f815bf7
Remove ts-jest warning when running tests
albertodiazdorado-tng Sep 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions frontend/jest.config.js
View file
Open in desktop
Expand Up @@ -3,6 +3,7 @@ module.exports = {
globals: {
'ts-jest': {
tsconfig: '<rootDir>/tsconfig-test.json',
packageJson: 'package.json',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ts-jest[config] (WARN) The option packageJson is deprecated and will be removed in ts-jest 27. This option is not used by internal ts-jest

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I can confirm this one. Remind me to actually try the stuff I review first ...
Still, I wonder why I never saw the original warning. Maybe it was a global ts-node or jest installation interfering?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I actually missed this one warning. I can try to reproduce the warnings, both on master and on this branch, and see if I missed something

},
API_URL: 'wss://api.url',
},
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Expand Up @@ -5,7 +5,7 @@
"scripts": {
"start": "cd frontend && vite",
"preview": "npm run build:frontend && cd frontend && vite preview",
"test": "npx jest --config frontend/jest.config.js",
"test": "jest --config frontend/jest.config.js",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1: we could leave this since its installed anyway

"build": "run-p build:backend build:frontend",
"lint": "prettier . --write",
"prepare": "husky install",
Expand Down