Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1177 course import deduplicate emails #1236

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

barisgul15
Copy link
Contributor

Motivation and Context

Issue 1177: https://github.com/orgs/TUM-Dev/projects/10/views/1?pane=issue&itemId=41336294
The array coming from TUMonline has some duplicates in contacts and these need to be eliminated.

Description

The data coming from TUMonline sometimes duplicates contacts of some courses. course.contacts has 5 attributes:
first_name, last_name, email, main_contact, role.
All cases considered, the most distinctive among them is e-mail. So a script is added to modify the array before it is used for course contacts while importing courses.

Steps for Testing

Prerequisites:

  • Having admin rights
  1. Log in
  2. Click admin in the menu
  3. Click import courses
  4. Find a course that used to have duplicate contacts: e.g. Einführung in die Games Eng(IN0031), IN2064, ...
  5. Confirm that there are not duplicate contacts anymore.

Screenshots

Before there was two Vortragender, Leiterin, but the course has only one actually:
twoTimesListedGames
After the changes, the duplicate is eliminated:
Games_duplicates_eliminated

@barisgul15 barisgul15 linked an issue Nov 17, 2023 that may be closed by this pull request
Copy link

Your Testserver will be ready at https://1236.test.live.mm.rbg.tum.de in a few minutes.

Logins
Kurs1 Kurs2 Kurs3 Kurs4
public public loggedin enrolled
prof1 prof1 prof2 prof1
prof2
student1
student2
student3
student1
student2
student2
student3
student1
student2

Copy link
Contributor

@SebiWrn SebiWrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the script tag to the correct typescript files and use it from there

@barisgul15
Copy link
Contributor Author

The location of the used filtering function is changed from course-import.gohtml to course-import.ts.

Copy link
Contributor

@SebiWrn SebiWrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is still an issue with the checkboxes, because you just change the value in the contacts from your method, but the send mail method still uses the whole contact list without the updated values.
With that I think the checkboxes won't work and everybody will get an email even if you don't select them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Course-Import]: deduplicate emails
2 participants