Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(scheduleGarbageCollection): Do not garbage collect newly cached queries of the same hash #332

Merged
merged 7 commits into from Apr 8, 2020
Merged

fix(scheduleGarbageCollection): Do not garbage collect newly cached queries of the same hash #332

merged 7 commits into from Apr 8, 2020

Commits on Apr 8, 2020

  1. Add manual/prefetch cleanup test that fails

    @kamranayub
    kamranayub committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    5c75a8e View commit details
    Browse the repository at this point in the history

  2. Prefetch both queries in second test

    @kamranayub
    kamranayub committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    3d1aa7a View commit details
    Browse the repository at this point in the history

  3. Add cleanup comment that will make the tests pass

    @kamranayub
    kamranayub committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    aa44aa9 View commit details
    Browse the repository at this point in the history

  4. Store when the GC was initiated and compare against updatedAt

    @kamranayub
    kamranayub committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    e30cf94 View commit details
    Browse the repository at this point in the history

  5. Replace solution with state marker check and streamline test

    @kamranayub
    kamranayub committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    5835d22 View commit details
    Browse the repository at this point in the history

  6. Undo setting.json change

    @kamranayub
    kamranayub committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    6976cb3 View commit details
    Browse the repository at this point in the history

  7. Undo setting.json change

    @kamranayub
    kamranayub committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    7dbb61a View commit details
    Browse the repository at this point in the history