test(useQuery): Ensure we await the rendered text we expect #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamranayub
commented
Apr 9, 2020
| waitForElement, | ||
| fireEvent, | ||
| } from '@testing-library/react' | ||
| import { render, act, waitForElement, fireEvent } from '@testing-library/react' |
There was a problem hiding this comment.
Prettier did this for me
kamranayub
commented
Apr 9, 2020
| @@ -152,9 +147,9 @@ describe('useQuery', () => { | |||
| ) | |||
| } | |||
|
|
|||
| const rendered = render(<Page />) | |||
| const { findByText } = render(<Page />) | |||
There was a problem hiding this comment.
Suspicion: due to GC happening on subsequent tests that was fixed in #332, this may have been passing as a fluke. The test before this ensures it's in a loading state by default, which is what the rendered output looks like for this test when it was failing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that CI was failing intermittently on a test and it was receiving an
act()warning. I believe it's because we should be awaiting the find of the text to allow for async work to happen inuseQuery.To reproduce locally, run
yarn testthenafor all tests, then hitEntertwice to do two full test runs in sequence. The subsequent runs should fail reliably on this test.This seemed to be introduced after my PR #332 perhaps due to fixing the GC issue, and a state update happening that isn't waited for during the test. Other tests do use
actto do assertions as well, plus usingfindfor components that do async work seems a lot more reliable.Changes
actwarning that happens on subsequent test runs for testshould be in "success" state by default in manual mode