Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query-core): allow multiple roots to share same QueryClient #4636

Merged
merged 4 commits into from Jan 4, 2023
Merged

fix(query-core): allow multiple roots to share same QueryClient #4636

merged 4 commits into from Jan 4, 2023

Commits on Dec 13, 2022

  1. fix(query-core): allow multiple roots to share same QueryClient 

    If two roots shared the `QueryClient` instance, then it would never unsubscribe from online/focus manager listeners and would also forever receive duplicate events because the unsubscriber functions would get "forgotten".

These issues would be especially noticeable on React Native apps where multiple roots that share the same `QueryClient` are common.
    @appden
    appden committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    ac7cbd3 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2022

  1. Merge branch 'main' into fix-multiple-roots

    @TkDodo
    TkDodo committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    f00b8e7 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2022

  1. test(QueryClient): Add test for multiple mounts, single unmount

    @appden
    appden committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    a5d7003 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2023

  1. Merge branch 'main' into fix-multiple-roots

    @TkDodo
    TkDodo committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    27ad7dc View commit details
    Browse the repository at this point in the history