New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: rename useErrorBoundar option to throwError #4697
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 47acfc5:
|
good point about that. Do you thin Also, can you please add a paragraph to the migration guide: query/docs/react/guides/migrating-to-react-query-5.md Lines 6 to 9 in cfb15ef
Oh, and the PR needs to go to the |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v5 #4697 +/- ##
=====================================
Coverage ? 92.39%
=====================================
Files ? 89
Lines ? 3748
Branches ? 985
=====================================
Hits ? 3463
Misses ? 269
Partials ? 16 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
I'm not sure about the plural version as it might imply that there are multiple errors being thrown, which is not the case, I believe. I'm happy to change it to the plural version if you think it is more fitting. Although, you're able to reset the error boundary, at which point there can be another error thrown, which makes it multiple.. |
Is it fine that the |
Here you go 04b033b |
hm, the id is the slug in the url. So maybe it should just be
yeah let'a go with |
Makes sense! Will do |
@allcontributors add @Moshyfawn for code |
I've put up a pull request to add @Moshyfawn! 🎉 |
throwError
name makes the most sense as it's a common name within request packages like ky (ex:throwHttpErrors
)Closes: #4677