Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(vue-query): migrate vue-query docs #4710

Merged
merged 7 commits into from Dec 29, 2022

Conversation

DamianOsipiuk
Copy link
Contributor

@TkDodo

  • added a bunch of content tokens to existing docs.
  • replaced React Query phrases with Tanstack Query where appropriate
  • run prettier on modified pages
  • added vue-query docs

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 26, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit dc82da0:

Sandbox Source
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-vue-basic Configuration

@codecov-commenter
Copy link

Codecov Report

Base: 96.36% // Head: 92.33% // Decreases project coverage by -4.02% ⚠️

Coverage data is based on head (dc82da0) compared to base (eab6e2c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4710      +/-   ##
==========================================
- Coverage   96.36%   92.33%   -4.03%     
==========================================
  Files          45       89      +44     
  Lines        2281     3744    +1463     
  Branches      640      981     +341     
==========================================
+ Hits         2198     3457    +1259     
- Misses         80      271     +191     
- Partials        3       16      +13     
Impacted Files Coverage Δ
src/react/reactBatchedUpdates.ts
src/core/hydration.ts
src/react/Hydrate.tsx
src/react/useBaseQuery.ts
src/react/logger.ts
src/react/useQuery.ts
src/core/focusManager.ts
src/core/queryObserver.ts
src/core/retryer.ts
src/react/useIsFetching.ts
... and 124 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@DamianOsipiuk
Copy link
Contributor Author

@TkDodo Do we need some changes here?

@TkDodo TkDodo merged commit 46fae94 into TanStack:main Dec 29, 2022
@TkDodo
Copy link
Collaborator

TkDodo commented Dec 29, 2022

merged :) do we need to merge the PR in the TanStack.com repo as well?

@DamianOsipiuk
Copy link
Contributor Author

@TkDodo Yes

@RihanArfan
Copy link

RihanArfan commented Dec 30, 2022

Shouldn't all imports of vue-query be changed to @tanstack/vue-query? I'm more than happy to make a PR if that's the case :)

@TkDodo
Copy link
Collaborator

TkDodo commented Dec 31, 2022

Shouldn't all imports of vue-query be changed to @tanstack/vue-query? I'm more than happy to make a PR if that's the case :)

yes, they should. did we not fix this with this PR ?

@RihanArfan
Copy link

Looks like it was done in #4728 already, perfect :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants