Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mutate callbacks called if mutation started after unmount #4848

Merged
merged 6 commits into from Jan 22, 2023
Merged

fix: mutate callbacks called if mutation started after unmount #4848

merged 6 commits into from Jan 22, 2023

Commits on Jan 21, 2023

  1. test: add mutation callback after unmount test

    @janlat
    janlat committed Jan 21, 2023
    Copy the full SHA
    431fc09 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2023

  1. test: make test more resilient

    @TkDodo
    TkDodo committed Jan 22, 2023
    Copy the full SHA
    a8f5632 View commit details
    Browse the repository at this point in the history

  2. fix(core): do not call mutate callbacks if mutation started after unm… 

    …ount
    @TkDodo
    TkDodo committed Jan 22, 2023
    Copy the full SHA
    f794bdd View commit details
    Browse the repository at this point in the history

  3. test: adapt tests to what we have in v5 

    - one test has been removed (because setState was removed entirely)
- the second test has been re-written to not use internals anymore, and it works in v4 as well
    @TkDodo
    TkDodo committed Jan 22, 2023
    Copy the full SHA
    14f6b61 View commit details
    Browse the repository at this point in the history

  4. fix(core): do not call mutate callbacks if mutation started after unm… 

    …ount

by making sure the callbacks are only invoked if we have an active listener
    @TkDodo
    TkDodo committed Jan 22, 2023
    Copy the full SHA
    2ad4a75 View commit details
    Browse the repository at this point in the history

  5. chore: prettier again

    @TkDodo
    TkDodo committed Jan 22, 2023
    Copy the full SHA
    e342cac View commit details
    Browse the repository at this point in the history