Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: basic-graphql-request link in v3 docs #5903

Merged
merged 1 commit into from Aug 24, 2023
Merged

fix: basic-graphql-request link in v3 docs #5903

merged 1 commit into from Aug 24, 2023

Conversation

cseas
Copy link
Contributor

@cseas cseas commented Aug 23, 2023

The example link on this page doesn't work currently:
https://tanstack.com/query/v3/docs/react/graphql

@vercel
Copy link

vercel bot commented Aug 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Visit Preview Aug 23, 2023 9:11pm

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 067e19e:

Sandbox Source
TanStack/query: basic Configuration
TanStack/query: basic-typescript Configuration

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (v3@a6436d8). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@          Coverage Diff          @@
##             v3    #5903   +/-   ##
=====================================
  Coverage      ?   96.36%           
=====================================
  Files         ?       45           
  Lines         ?     2281           
  Branches      ?      640           
=====================================
  Hits          ?     2198           
  Misses        ?       80           
  Partials      ?        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TkDodo TkDodo merged commit dd3f2a7 into TanStack:v3 Aug 24, 2023
7 checks passed
@cseas cseas deleted the v3 branch August 25, 2023 00:09
@cseas
Copy link
Contributor Author

cseas commented Aug 25, 2023

Looks like this didn't work. The relative path in the code now points to the correct file, but the url finally getting rendered still isn't correct.

Now it is: https://tanstack.com/query/v3/docs/react/examples/basic-graphql-request
Should be: https://tanstack.com/query/v3/docs/react/examples/react/basic-graphql-request

I searched through the code for references of something that does work and looks like all relative links are broken in v3 docs. For example, the simple and basic examples here: https://tanstack.com/query/v3/docs/react/examples/react/basic-graphql-request

Should I create another pull request to point these to absolute URLs instead with full path to the website page?
All these links likely started breaking after this change: #4890
cc: @TkDodo @tannerlinsley @DamianOsipiuk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants