New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vue-query): add support for infiniteQueryOptions #7257
base: main
Are you sure you want to change the base?
feat(vue-query): add support for infiniteQueryOptions #7257
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 3f55dbe. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
57bd093
to
3f55dbe
Compare
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3f55dbe:
|
Hola @TkDodo When you can, could I get some feedback on this PR? Thank you so much! |
It also do not exist for solid-query. Maybe it makes sense to add function type to the core package for easier reuse? |
Idk if you can share the implementation, some type for example on vue are constrained to vue types, do you have any ideas? |
Probably I need to make contribution with the 95% the same copy pasted code. Because there is not actual logic - only types that changes from framework to framework const options = queryOptions(() => ({
queryKey: ['sadf', 'sadf'],
queryFn: () => Promise.resolve([1,2])
}))
const query = createQuery(() => ({
// awakward, if we use key factroy it willl be factory.options({ ... })()
...options(),
select: it => it[0]
})) Oh seems to be now implementations changed and it just uses plain object, not callback |
Btw, in this implementation and react implementation pageParams has always |
Uhm I just followed what was being done on react |
|
I see. Problem is that |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #7257 +/- ##
==========================================
- Coverage 41.42% 40.99% -0.44%
==========================================
Files 184 183 -1
Lines 7331 7370 +39
Branches 1531 1534 +3
==========================================
- Hits 3037 3021 -16
- Misses 3889 3938 +49
- Partials 405 411 +6 |
The goal of this PR is to support the
infiniteQueryOptions
utility as it already does for react:https://tanstack.com/query/latest/docs/framework/react/reference/infiniteQueryOptions
TODO: