fix(start): tsc the config package

TanStack · May 15, 2024 · 5d48fd6 · 5d48fd6
1 parent 8ae2cee
commit 5d48fd6
Show file tree

Hide file tree

Showing 4 changed files with 33 additions and 16 deletions.
diff --git a/packages/start/config.tsconfig.json b/packages/start/config.tsconfig.json
@@ -0,0 +1,9 @@
+{
+  "extends": "../../tsconfig.json",
+  "include": ["src/config/index.ts"],
+  "compilerOptions": {
+    "outDir": "dist/esm/config",
+    "target": "esnext",
+    "noEmit": false
+  }
+}
diff --git a/packages/start/package.json b/packages/start/package.json
@@ -28,8 +28,8 @@
     },
     "./config": {
       "import": {
-        "_types": "./src/config/index.d.ts",
-        "default": "./src/config/index.js"
+        "types": "./dist/esm/config/index.d.ts",
+        "default": "./dist/esm/config/index.js"
       }
     },
     "./client": {
@@ -90,7 +90,8 @@
     "test:eslint": "eslint --ext .ts,.tsx ./src",
     "test:types": "tsc --noEmit",
     "test:build": "publint --strict",
-    "build": "vite build"
+    "build": "vite build && pnpm build:config",
+    "build:config": "tsc --project config.tsconfig.json"
   },
   "keywords": [
     "react",

diff --git a/packages/start/src/config/index.js → packages/start/src/config/index.ts b/packages/start/src/config/index.js → packages/start/src/config/index.ts
@@ -10,21 +10,29 @@ import { TanStackRouterVite } from '@tanstack/router-vite-plugin'
 import { serverFunctions } from '@vinxi/server-functions/plugin'
 import { serverTransform } from '@vinxi/server-functions/server'
 import { config } from 'vinxi/plugins/config'
-// import type * as vite from 'vite'
+import type * as vite from 'vite'
 // import { config } from 'vinxi/plugins/config'
 
 function startVite() {
   return config('start-vite', {
     ssr: {
-      // external: ['@tanstack/start'],
+      // external: [
+      //   '@tanstack/start/client-runtime',
+      //   '@tanstack/start/server-runtime',
+      //   '@tanstack/start/server-handler',
+      // ],
     },
     optimizeDeps: {
       // exclude: ['@tanstack/start'],
     },
   })
 }
 
-export function defineConfig(opts) {
+export function defineConfig(opts?: {
+  vite?: {
+    plugins: () => Array<vite.UserConfig>
+  }
+}) {
   return createApp({
     server: {
       preset: 'vercel',
@@ -47,15 +55,15 @@ export function defineConfig(opts) {
         target: 'server',
         plugins: () => [
           startVite(),
-          opts.vite?.(),
+
           TanStackRouterVite({
             experimental: {
-              enableCodeSplitting: false,
+              enableCodeSplitting: true,
             },
           }),
           tsconfigPaths(),
           serverTransform({
-            runtime: resolveRelativePath('../server-runtime/index.tsx'),
+            runtime: resolveRelativePath('../server-runtime'),
           }),
         ],
         link: {
@@ -74,23 +82,23 @@ export function defineConfig(opts) {
         plugins: () => [
           TanStackRouterVite({
             experimental: {
-              enableCodeSplitting: false,
+              enableCodeSplitting: true,
             },
           }),
           startVite(),
-          opts.vite?.(),
+
           tsconfigPaths(),
           serverFunctions.client({
-            runtime: resolveRelativePath('../client-runtime/index.tsx'),
+            runtime: resolveRelativePath('../client-runtime'),
           }),
           reactRefresh(),
         ],
       },
       serverFunctions.router({
         name: 'server',
-        plugins: () => [startVite(), opts.vite?.(), tsconfigPaths()],
-        handler: resolveRelativePath('../server-handler/index.tsx'),
-        runtime: resolveRelativePath('../server-runtime/index.tsx'),
+        plugins: () => [startVite(), tsconfigPaths()],
+        handler: resolveRelativePath('../server-handler'),
+        runtime: resolveRelativePath('../server-runtime'),
       }),
     ],
   })

diff --git a/packages/start/vite.config.ts b/packages/start/vite.config.ts
@@ -40,7 +40,6 @@ export default mergeConfig(
   config,
   tanstackBuildConfig({
     entry: [
-      './src/constants.ts',
       './src/client/index.tsx',
       './src/server/index.tsx',
       './src/client-runtime/index.tsx',