fix: createBrowserHistory's createHref option

[hi-ogawa]

Related to my comment at the bottom of #1441 (comment), this looks to me like a minor typo.

It looks like createHref option is not currently used by @tanstack/react-router itself and I'm actually not sure what's the main use case, but as explained in the issue comment, I'm thinking to use this to fix history location encoding issue on my framework.

Please let me know if I missed something. Also I wasn't sure where a test belong to (or whether a new test is needed), so any pointers about testing would be appreciated. Thanks!

[hi-ogawa]

I came to realize that this is not a typo and it's very much intended not to do currentLocation = parseHref(createHref(destHref), ...).

The reason being, I think createHref and parseLocation work in a following way:

• createHref: (application href) --> (actual browser href)
• parseLocation: (actual browser state) -> (application location object)

For example, this architecture will probably allow pre-pending base path, which are not visible to application. Doing currentLocation = parseHref(createHref(destHref), ...)) will break such feature.

I'm happy to close this PR, but it would be awesome if someone from the team can confirm if my reasoning is correct.