fix(router-generator): generator should not infer trailing slash is not necessary for index routes

[chorobin]

Trailing slashes should only be there if the index route has to be uniquely identified by it.

fixes #1596

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2e0605e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 2 targets

• nx affected --targets=test:format,test:eslint,test:unit,test:build,build --parallel=3
• nx affected --target=test:types --exclude=examples/**

---

Sent with 💌 from NxCloud.

[chorobin]

Not sure if the id should have a trailing slash or not? But at least this fixes the fullPath and path. TS used to normalize this but its right to move this work to the generator as we don't want the compiler spending time on stuff the generator can do

[SeanCassiere]

Where is this id field meant to be used in Router?

If it is being used in places like useSearch, and hooks that use from, then trailing-slashes should be removed (with the exception to index routes).

For example, in the basic example, from accepts the following options regardless of the trailingSlash setting.

/
/posts
/posts/
/posts/$postId
__root__

[chorobin]

Let me clarify. These are index routes that I'm removing trailing slashes from. It's index routes without a route.tsx which was causing the problem. Before I guess TS was removing this slash, then I moved it to the generator and fullPath got a trailing slash in this situation.

So do you think id should have a trailing slash or not in this situation? Because TFilePath does have one and I guess always had one

[chorobin]

I just checked previous versions and id always had a trailing slash in this situation. I'm going to merge

[TkDodo]

Do we have a test for different trailingSlash settings too?

[chorobin]

Do we have a test for different trailingSlash settings too?

We have loads at the type level. The problem was the types expect fullPath to not have trailing slashes by default.

https://github.com/TanStack/router/blob/main/packages/react-router/tests/link.test-d.tsx

I think the generator tests should cover that the generated types are correct

[SeanCassiere]

Where is this id field meant to be used in Router?

If it is being used in places like useSearch, and hooks that use from, then trailing-slashes should be removed (with the exception to index routes).

For example, in the basic example, from accepts the following options regardless of the trailingSlash setting.

/
/posts
/posts/
/posts/$postId
__root__

[SeanCassiere]

@chorobin looks good on my-side, just left a comment regarding the id value.