Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add autoResetSorting #5414

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

tychenjiajun
Copy link
Contributor

No description provided.

Copy link

nx-cloud bot commented Mar 16, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 86a854c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@KevinVandy
Copy link
Member

What's the use-case for this? Usually changing the sorting state without user-input is bad UX, right?

@tychenjiajun
Copy link
Contributor Author

What's the use-case for this? Usually changing the sorting state without user-input is bad UX, right?

Personally I agree that changing the sorting state without user-input is bad UX. But there's still some designers prefer automatically resetting the sorting state when data changes.

@tychenjiajun
Copy link
Contributor Author

Also, see #5217

@KevinVandy
Copy link
Member

KevinVandy commented Mar 19, 2024

ok, open to merging this, but need to test more. Definitely agree that this should not be enabled by default like some of the other autoReset options though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants