Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev/ipv6 #90

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

dev/ipv6 #90

wants to merge 1 commit into from

Conversation

t4110
Copy link
Contributor

@t4110 t4110 commented Feb 24, 2022 •
edited

  • feat: normalize IPv6 address in URL
  • Merge branch 'master' into dev/ipv6

ref: https://github.com/TeamMomentum/development/discussions/5

@t4110 t4110 changed the base branch from master to develop February 24, 2022 13:55
@t4110 t4110 changed the base branch from develop to master February 24, 2022 13:58
@t4110 t4110 changed the base branch from master to develop February 24, 2022 14:00
@t4110 t4110 changed the base branch from develop to master February 24, 2022 14:02
@t4110 t4110 changed the base branch from master to develop February 24, 2022 14:02
dictav
dictav reviewed Feb 28, 2022
View reviewed changes
testdata/norm_ipv6.json Outdated Show resolved Hide resolved
@t4110
Copy link
Contributor Author

t4110 commented Feb 28, 2022

jsについて、NodeのURL APIによる new URL() とbqのUDF用に使っているurl-parseの new URL() でIPv6をparseしたときの挙動が違いますね 😓

URL API: RFC 5952推奨表記に書き換え
url-parse: 元URLをそのまま

@dictav dictav mentioned this pull request Apr 27, 2022
Closed
@t4110 t4110 changed the base branch from develop to master May 20, 2022 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dictav dictav dictav left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@t4110 @dictav