Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[php] Fix #9021 fail to build grpc #9032

Merged
merged 3 commits into from
May 23, 2024
Merged

Conversation

joanhey
Copy link
Contributor

@joanhey joanhey commented May 16, 2024

Remove grpc, not necessary and the container build is a lot of faster.

Add OPCache and JIT.
Use composer bin directly.

Still fail the update test, that was failing in the runs for a lot of time.

@joanhey joanhey marked this pull request as ready for review May 17, 2024 11:23
@joanhey
Copy link
Contributor Author

joanhey commented May 17, 2024

The update test fail, like before, but it'll be fixed in another PR.
Actually with the #9021 fail building the container, and it's very slow building (+10 min) til fail, now ~3 min.

for faster local builds when only change the code
@NateBrady23 NateBrady23 merged commit b283599 into TechEmpower:master May 23, 2024
2 of 3 checks passed
@joanhey joanhey deleted the spiral-fix branch May 24, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants