Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding --cpuset-cpus tfb argument to set it on the server container #9035

Merged
merged 1 commit into from
May 23, 2024

Conversation

franz1981
Copy link
Contributor

Hi @NateBrady23 I found this option very useful in our lab tests (eg to avoid NUMA effects on our servers): I think the same could be done for the database/client, but given that the concurrency limits kind of mess with the required resources I didn't pushed this further.

I haven't been able to do the same by using the existing extra arguments in the tfb command, getting:

$ ./tfb --mode debug --test quarkus --type plaintext --extra-docker-runtime-args cpuset-cpus:1,3
# ...
# ...
quarkus: Running docker container: quarkus.dockerfile failed
quarkus: Traceback (most recent call last):
quarkus:   File "/FrameworkBenchmarks/toolset/utils/docker_helper.py", line 220, in run
quarkus:     container = self.server.containers.run(
quarkus:                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^
quarkus:   File "/usr/local/lib/python3.12/dist-packages/docker/models/containers.py", line 873, in run
quarkus:     container = self.create(image=image, command=command,
quarkus:                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
quarkus:   File "/usr/local/lib/python3.12/dist-packages/docker/models/containers.py", line 931, in create
quarkus:     create_kwargs = _create_container_args(kwargs)
quarkus:                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
quarkus:   File "/usr/local/lib/python3.12/dist-packages/docker/models/containers.py", line 1159, in _create_container_args
quarkus:     raise create_unexpected_kwargs_error('run', kwargs)
quarkus: TypeError: run() got an unexpected keyword argument 'cpuset-cpus'

@NateBrady23 NateBrady23 merged commit 912ab8b into TechEmpower:master May 23, 2024
24 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants