Use clone_from to fix clippy violation

TedDriggs · May 13, 2024 · bb36185 · bb36185
1 parent 78f3d11
commit bb36185
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 10 deletions.
diff --git a/core/src/options/from_derive.rs b/core/src/options/from_derive.rs
@@ -54,15 +54,15 @@ impl ParseData for FdiOptions {
     fn parse_field(&mut self, field: &syn::Field) -> Result<()> {
         match field.ident.as_ref().map(|v| v.to_string()).as_deref() {
             Some("vis") => {
-                self.vis = field.ident.clone();
+                self.vis.clone_from(&field.ident);
                 Ok(())
             }
             Some("data") => {
-                self.data = field.ident.clone();
+                self.data.clone_from(&field.ident);
                 Ok(())
             }
             Some("generics") => {
-                self.generics = field.ident.clone();
+                self.generics.clone_from(&field.ident);
                 Ok(())
             }
             _ => self.base.parse_field(field),

diff --git a/core/src/options/from_field.rs b/core/src/options/from_field.rs
@@ -39,11 +39,11 @@ impl ParseData for FromFieldOptions {
     fn parse_field(&mut self, field: &syn::Field) -> Result<()> {
         match field.ident.as_ref().map(|v| v.to_string()).as_deref() {
             Some("vis") => {
-                self.vis = field.ident.clone();
+                self.vis.clone_from(&field.ident);
                 Ok(())
             }
             Some("ty") => {
-                self.ty = field.ident.clone();
+                self.ty.clone_from(&field.ident);
                 Ok(())
             }
             _ => self.base.parse_field(field),

diff --git a/core/src/options/from_type_param.rs b/core/src/options/from_type_param.rs
@@ -39,11 +39,11 @@ impl ParseData for FromTypeParamOptions {
     fn parse_field(&mut self, field: &syn::Field) -> Result<()> {
         match field.ident.as_ref().map(|v| v.to_string()).as_deref() {
             Some("bounds") => {
-                self.bounds = field.ident.clone();
+                self.bounds.clone_from(&field.ident);
                 Ok(())
             }
             Some("default") => {
-                self.default = field.ident.clone();
+                self.default.clone_from(&field.ident);
                 Ok(())
             }
             _ => self.base.parse_field(field),

diff --git a/core/src/options/from_variant.rs b/core/src/options/from_variant.rs
@@ -59,11 +59,11 @@ impl ParseData for FromVariantOptions {
     fn parse_field(&mut self, field: &Field) -> Result<()> {
         match field.ident.as_ref().map(|v| v.to_string()).as_deref() {
             Some("discriminant") => {
-                self.discriminant = field.ident.clone();
+                self.discriminant.clone_from(&field.ident);
                 Ok(())
             }
             Some("fields") => {
-                self.fields = field.ident.clone();
+                self.fields.clone_from(&field.ident);
                 Ok(())
             }
             _ => self.base.parse_field(field),

diff --git a/core/src/options/outer_from.rs b/core/src/options/outer_from.rs
@@ -78,7 +78,7 @@ impl ParseData for OuterFrom {
     fn parse_field(&mut self, field: &Field) -> Result<()> {
         match field.ident.as_ref().map(|v| v.to_string()).as_deref() {
             Some("ident") => {
-                self.ident = field.ident.clone();
+                self.ident.clone_from(&field.ident);
                 Ok(())
             }
             Some("attrs") => {