Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when parsing FromMeta containing NestedMeta::Lit #193

Merged
merged 8 commits into from Sep 8, 2022
Merged

Error when parsing FromMeta containing NestedMeta::Lit #193

merged 8 commits into from Sep 8, 2022

Commits on Jul 24, 2022

  1. Add tests capturing existing behavior

    @leighmcculloch
    leighmcculloch committed Jul 24, 2022
    Copy the full SHA
    0242a4c View commit details
    Browse the repository at this point in the history

  2. write a failing test for desired behavior

    @leighmcculloch
    leighmcculloch committed Jul 24, 2022
    Copy the full SHA
    8224ffb View commit details
    Browse the repository at this point in the history

  3. expect unsupported literal instead which is more consistent with othe… 

    …r error generation in darling
    @leighmcculloch
    leighmcculloch committed Jul 24, 2022
    Copy the full SHA
    f97a0b6 View commit details
    Browse the repository at this point in the history

  4. handle the literal case

    @leighmcculloch
    leighmcculloch committed Jul 24, 2022
    Copy the full SHA
    385c547 View commit details
    Browse the repository at this point in the history

  5. refactor if-else to match

    @leighmcculloch
    leighmcculloch committed Jul 24, 2022
    Copy the full SHA
    a9cf414 View commit details
    Browse the repository at this point in the history

  6. fix fmting of test

    @leighmcculloch
    leighmcculloch committed Jul 24, 2022
    Copy the full SHA
    04ef351 View commit details
    Browse the repository at this point in the history

  7. add some some additional but non-exhaustive test cases

    @leighmcculloch
    leighmcculloch committed Jul 24, 2022
    Copy the full SHA
    6877e1c View commit details
    Browse the repository at this point in the history

  8. tighten span on literal

    @leighmcculloch
    leighmcculloch committed Jul 24, 2022
    Copy the full SHA
    5c6c206 View commit details
    Browse the repository at this point in the history