-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/parse attr #279
Feature/parse attr #279
Conversation
Signed-off-by: DragonBillow <DragonBillow@outlook.com>
Signed-off-by: DragonBillow <DragonBillow@outlook.com>
Signed-off-by: DragonBillow <DragonBillow@outlook.com>
Signed-off-by: DragonBillow <DragonBillow@outlook.com>
In the previous pr, you add a comment: #277 (comment), I don't quite understand what you mean. What function do you want to achieve, or what is wrong with the current implementation? |
I expect this to pass: |
Can you give a more detailed, working example? (Can be used to test parse_meta) |
If I could give you a working example, then the PR wouldn't need amendment. Try using the macro with anything that contains a comma, and you get an error because the |
I don't quite understand the purpose of this way of writing. What is inner(example::flag, my_feature)? Is it a function that returns a TokenStream? |
Oh, wow, I'm sorry - this is entirely on me. I was mistakenly thinking of this as |
This feature merging cycle far exceeded my expectations. On the one hand, considering that no obvious progress has been seen yet, on the other hand, this function has been completed. So I closed this pr. If you are still interested in this macro. You can implement it on your own branch. |
continue of #277
NOTE: I add the permission, so you can push commits to cathaysia:feature/parse_attr, then it will autoupdate to this pr.