Bump to edition 2021 #281
Merged
Bump to edition 2021 #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like most of the code change here is due to the
Looking around further, it seems that use of that specific lint is not universally popular (source). I'm otherwise supportive of this PR. What would your thoughts be on allowing that one lint, and otherwise warning on 2018 idioms? |
|
I personally would take dtolnay's opinions with a grain of salt, as he opposes a lot of common guidelines. I have never seen a codebase which does not follow this lint and is using rust_2018_idioms, so would be quite opposed to not following common guideline. |
|
You’re right… it just looks uglier |
TedDriggs
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This crate is still on edition 2018 but it's MSRV is exactly the MSRV needed for 2021... so let's get this over with. It turns out that there were no changes required, but I fixed all the things missed for the 2018 migration by adding
#![warn(rust_2018_idioms)].