Fix cargo test --no-default-features
#284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The suggestion is not given when the `suggestions` Cargo feature is disabled.
TedDriggs
requested changes
Apr 9, 2024
Oh, of course! I had the change locally and just transcribed it to the GitHub editor... but not 100% accurately :-D Co-authored-by: Ted Driggs <ted.driggs@outlook.com>
TedDriggs
approved these changes
Apr 11, 2024
|
Now the one open question in my mind - why didn't CI catch this before? Don't need to block this PR for it, but do need to sort that out. |
I think it's because you're not running all tests with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The suggestion is not given when the
suggestionsCargo feature is disabled.