feat: Add FromMeta support for BTreeMap
#287
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code for this looks fine to me, but I am curious what the use-case is that needs this. Are you doing something that needs the keys to always be sorted? |
|
Yeah I had a very rare use-case where this behaviour was required. But I can see that this feature seems to be needed very rarely. |
|
@Techassi is this something you'd still use if it was merged? If so, can you elaborate on the use-case? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
FromMetaimplementation forBTreeMap<String, V>andBTreeMap<syn::Ident, V>by adjusting the existing macro. The macro can now handle bothHashMapandBTreeMap, because much of the underlying code is the same.I also added new unit tests to test the
BTreeMapimplementation.