Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show dialog not use root navigator #3475

Open
wants to merge 271 commits into
base: main
Choose a base branch
from

Conversation

JasonZengJ
Copy link

Before submitting a new pull request, please make sure:

  • [ √] Test cases have been added/updated/passed for the code you will submit.
  • [ √] Documentation has added or updated.
  • [ √] Commit message is following the Convention Commit guideline with maximum 72 characters.
  • [ √] Squash the repeat code commits, short patches are welcome.

@github-actions github-actions bot added renderer: voltron size: xs Denotes a PR that changes 0-9 lines labels Aug 31, 2023
@tencent-adm
Copy link

tencent-adm commented Aug 31, 2023

CLA assistant check
All committers have signed the CLA.

@hippy-service
Copy link

hippy-service bot commented Aug 31, 2023

Hi, @JasonZengJ. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@hippy-service
Copy link

hippy-service bot commented Aug 31, 2023

After a quick scan, I have approved workflow to run.

🏷️ New commits in this PR would not be tested automatically until this pull request is reviewed by our collaborators.
🏷️ No need to worry about the status of merge_guard and [gh] pull request merge guard / merge_guard (pull_request_target) checks, once this pull request is met merge requirements, it will be automatically converted to successful status.

@JasonZengJ JasonZengJ force-pushed the bugfix/compatible_with_trouter branch from 03d97af to 5ca2886 Compare August 31, 2023 09:28
@lvfen lvfen closed this Aug 31, 2023
@lvfen lvfen reopened this Aug 31, 2023
@hippy-service
Copy link

hippy-service bot commented Aug 31, 2023

After a quick scan, I have approved workflow to run.

🏷️ New commits in this PR would not be tested automatically until this pull request is reviewed by our collaborators.
🏷️ No need to worry about the status of merge_guard and [gh] pull request merge guard / merge_guard (pull_request_target) checks, once this pull request is met merge requirements, it will be automatically converted to successful status.

@hippy-service
Copy link

hippy-service bot commented Sep 1, 2023

🎉 It seems that this pull request has been approved by all required reviewers. As it only contains one normal commit, I will rebase and merge it automatically via add action(rebase-merge) label.

@hippy-service hippy-service bot added the action(rebase-merge) Rebase and merge action (maybe privileged) label Sep 1, 2023
@hippy-actions hippy-actions bot enabled auto-merge (rebase) September 1, 2023 02:09
@hippy-actions hippy-actions bot removed the action(rebase-merge) Rebase and merge action (maybe privileged) label Sep 1, 2023
@hippy-service
Copy link

hippy-service bot commented Sep 4, 2023

🎉 It seems that this pull request has been approved by all required reviewers. As it only contains one normal commit, I will rebase and merge it automatically via add action(rebase-merge) label.

@hippy-service hippy-service bot added the action(rebase-merge) Rebase and merge action (maybe privileged) label Sep 4, 2023
@hippy-actions hippy-actions bot enabled auto-merge (rebase) September 4, 2023 01:53
@hippy-actions hippy-actions bot removed the action(rebase-merge) Rebase and merge action (maybe privileged) label Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
renderer: voltron size: xs Denotes a PR that changes 0-9 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants