adapter to harmonyos for xlog #1224
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiemuhua
reviewed
Mar 25, 2024
There was a problem hiding this comment.
我觉得add_definitions(-DOHOS)放到编译脚本中更好，不要每个CMakeLists.txt都加一遍
tiemuhua
reviewed
Mar 25, 2024
There was a problem hiding this comment.
__BEGIN_EXTERN_C/__END_EXTERN_C应该是定义在sys/cdefs.h中的，如果目前鸿蒙没有提供相应的头文件的话，我认为应该在项目中新加一个sys/cdefs.h，而不是把__BEGIN_EXTERN_C定义到现有的项目文件中。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.