test(Alert): add onClosed test
#3756
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RSS1102
requested review from
PengYYYYY,
chaishi,
xiaosansiji,
honkinglin,
LeeJim and
uyarn
as code owners
|
|
uyarn
requested changes
Dec 17, 2023
| arr.push('fn2'); | ||
| }; | ||
| const wrapper = mount(() => ( | ||
| <Alert close onClose={fn1()} onClosed={fn2()}> |
There was a problem hiding this comment.
对应的是mock事件 不是执行事件
测试这种事件API有没有执行 用BeCalled expect 数组有没有和它执行没关系吧
There was a problem hiding this comment.
主要是想测试他的先后执行顺序，根据数组数据的先后判断。
There was a problem hiding this comment.
by accident..
只是因为你在mount里写的顺序 fn() 是直接执行这个函数 不是等回调执行了来执行
刚好fn1被你写在fn2之前了 所以也就fn1先执行了 你试试把这两个换顺序是不是直接挂了..
<Alert close onClosed={fn2()} onClose={fn1()}>
There was a problem hiding this comment.
Suggested change
| <Alert close onClose={fn1()} onClosed={fn2()}> | |
| <Alert close onClose={fn1} onClosed={fn2}> |
There was a problem hiding this comment.
主要是想测试他的先后执行顺序，根据数组数据的先后判断。
这个思路是可以的 就是具体内容得调整下
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
📝 更新日志
fix(组件名称): 处理问题或特性描述 ...
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单