-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correction in markdown table alignment #2077
Conversation
function changeStyleAlignmentToClass(html: string) { | ||
if (html) { | ||
const document: Document = new DOMParser().parseFromString( | ||
html, |
Check warning
Code scanning / CodeQL
DOM text reinterpreted as HTML Medium
DOM text
DOM text
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this might be valid catch here. consider using some like DomSanitizer before parsing this
https://angular.io/api/platform-browser/DomSanitizer#sanitize
closes #2008 |
function changeStyleAlignmentToClass(html: string) { | ||
if (html) { | ||
const document: Document = new DOMParser().parseFromString( | ||
html, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this might be valid catch here. consider using some like DomSanitizer before parsing this
https://angular.io/api/platform-browser/DomSanitizer#sanitize
🎉 This PR is included in version 7.4.7 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
Correction for markdown tables alignment
What's included?
Fix for the alignment in the markdown tables
General Tests for Every PR
npm run start
still works.npm run lint
passes.npm run stylelint
passes.npm test
passes and code coverage is not lower.npm run build
still works.