feat(components): adding fill to toggled on icon button #2144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamnel
previously approved these changes
Apr 12, 2024
|
Fill toggling looks good. We made a modification to the toggled state vs default material to leave a highlight effect behind it when active, which is missing here though:
|
owilliams320
force-pushed
the
feat/icon-toggle-fill
branch
from
7f31f94
to
cbf87ae
Compare
adamnel
previously approved these changes
Apr 12, 2024
adamnel
approved these changes
Apr 12, 2024
|
🎉 This PR is included in version 8.10.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Setting icon toggle button to be "filled" when toggled on
What's included?
Test Steps
npm run storybookGeneral Tests for Every PR
npm run startstill works.npm run lintpasses.npm run stylelintpasses.npm testpasses and code coverage is not lower.npm run buildstill works.Screenshots or link to StackBlitz/Plunker
Screen.Recording.2024-04-12.at.9.49.37.AM.mov