Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app-shell): enhancement to be resizable app-shell #2152

Merged
merged 3 commits into from
May 13, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
39 changes: 30 additions & 9 deletions libs/components/src/app-shell/app-shell.scss
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@
height: 100vh;
grid-area: main;
overflow: auto;
transition: margin 200ms ease-in-out;

.main-wrapper {
margin: 0 auto;
Expand Down Expand Up @@ -100,10 +99,6 @@
.cov-drawer--open & {
margin-left: 256px;
}

.cov-help--open & {
margin-right: 320px;
}
}

@media only screen and (max-width: 1600px) {
Expand All @@ -117,11 +112,37 @@
grid-area: help;
position: fixed;
right: 0;
width: 320px;
width: var(--help-width, 320px);
height: 100vh;
overflow-y: auto;
transition-property: width;
transition-duration: 200ms;

.resize-handle {
position: absolute;
left: 0;
width: 10px;
height: 100vh;
cursor: ew-resize;
z-index: 1100;
user-select: none;

&::after {
content: '';
position: absolute;
left: 50%;
top: 0;
width: 2px;
height: 100%;
background-color: var(--mdc-theme-primary);
transform: translateX(-50%);
transition: opacity 0.3s ease;
opacity: 0;
}

&:hover::after,
&.resizing::after {
opacity: 1;
}
}

.cov-help--closed & {
width: 0;
Expand Down Expand Up @@ -152,7 +173,7 @@

.current-section-name {
opacity: 0;
transition: opacity 150ms;
transition: opacity 200ms;

:host([open]) & {
opacity: 1;
Expand Down
126 changes: 124 additions & 2 deletions libs/components/src/app-shell/app-shell.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,11 @@ export class CovalentAppShell extends DrawerBase {
`,
];

element = document.querySelector('.help');
helpWidth = 0;
private _startX!: number;
private _startWidth!: number;

@queryAssignedElements({ slot: 'navigation' })
navigationListElements!: HTMLElement[];

Expand Down Expand Up @@ -77,8 +82,114 @@ export class CovalentAppShell extends DrawerBase {

constructor() {
super();
this._resize = this._resize.bind(this);
this._stopResize = this._stopResize.bind(this);
this._startResizing = this._startResizing.bind(this);
this._setupEventListeners();
window.addEventListener('DOMContentLoaded', () => {
this.setupHelpPanelListeners();
this.resizeEvent();
const storedWidth = localStorage.getItem('helpWidth');
if (storedWidth) {
this.helpWidth = parseInt(storedWidth, 10);
this.updateHelpPanelWidth();
}
});
}

setupHelpPanelListeners() {
const helpToggle = document.querySelector('.help-item');
const helpClose = document.querySelector('.help-close');

helpToggle?.addEventListener('click', () => {
this.toggleHelpPanel();
});

helpClose?.addEventListener('click', () => {
this.toggleHelpPanel(false);
});
}

toggleHelpPanel(open?: boolean) {
this.helpOpen = open !== undefined ? open : !this.helpOpen;
if (this.helpOpen) {
const storedWidth = localStorage.getItem('helpWidth');
this.helpWidth = storedWidth ? parseInt(storedWidth, 10) : 320;
} else {
this.helpWidth = 0;
}
this.updateHelpPanelWidth();
this.requestUpdate();
}

private _setupEventListeners() {
window.addEventListener('DOMContentLoaded', () => {
const helpToggle = document.querySelector('.help-item');
const helpClose = document.querySelector('.help-close');

helpToggle?.addEventListener('click', () => {
this.helpOpen = !this.helpOpen;
this.helpWidth = this.helpOpen ? 320 : 0;
this.requestUpdate();
});

helpClose?.addEventListener('click', () => {
this.helpOpen = false;
this.helpWidth = 0;
this.requestUpdate();
});
});
}

override firstUpdated() {
const resizeHandle = this.shadowRoot?.querySelector('.resize-handle');
if (resizeHandle) {
resizeHandle.addEventListener('mousedown', (event) => {
if (event instanceof MouseEvent) {
this._startResizing(event);
}
});

resizeHandle.addEventListener('dblclick', () => {
if (this.helpWidth > 320 || this.helpWidth !== 320) {
this.helpWidth = 320;
localStorage.setItem('helpWidth', '320');
this.updateHelpPanelWidth();
this.requestUpdate();
}
});
}
}

this.resizeEvent();
private _startResizing(event: MouseEvent) {
const resizeHandle = this.shadowRoot?.querySelector('.resize-handle');
if (event.target === resizeHandle) {
this._startX = event.clientX;
this._startWidth = this.helpWidth;
document.addEventListener('mousemove', this._resize);
document.addEventListener('mouseup', this._stopResize);
(event.target as HTMLElement).classList.add('resizing');
}
}

private _resize(event: MouseEvent) {
const diff = event.clientX - this._startX;
const newWidth = Math.max(320, Math.min(600, this._startWidth - diff));
if (this.helpWidth !== newWidth) {
this.helpWidth = newWidth;
localStorage.setItem('helpWidth', this.helpWidth.toString());
this.updateHelpPanelWidth();
}
event.preventDefault();
}

private _stopResize() {
document.removeEventListener('mousemove', this._resize);
document.removeEventListener('mouseup', this._stopResize);
const resizeHandle = this.shadowRoot?.querySelector('.resize-handle');
if (resizeHandle) {
resizeHandle.classList.remove('resizing');
}
}

private _toggleOpen(forcedOpen = false) {
Expand All @@ -95,6 +206,16 @@ export class CovalentAppShell extends DrawerBase {
this.requestUpdate();
}

private updateHelpPanelWidth() {
const helpPanel = this.shadowRoot?.querySelector('.help') as HTMLElement;
const mainPanel = this.shadowRoot?.querySelector('.main') as HTMLElement;

if (helpPanel && mainPanel) {
helpPanel.style.setProperty('--help-width', `${this.helpWidth}px`);
mainPanel.style.marginRight = `${this.helpWidth}px`;
}
}

private _handleMenuClick() {
this.mdcRoot.dispatchEvent(
new Event('transitionend', { bubbles: true, composed: true })
Expand Down Expand Up @@ -229,7 +350,8 @@ export class CovalentAppShell extends DrawerBase {
${this.renderMain()}
</div>
</div>
<div class="help">
<div class="help" @mousedown="${this._startResizing}">
<div class="resize-handle"></div>
<slot name="help"></slot>
</div>
</div>
Expand Down