Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): moving subnav property to nav-item component #2153

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

owilliams320
Copy link
Collaborator

@owilliams320 owilliams320 commented Apr 29, 2024

Description

moving the required subNav property from the list component scss to the cv-navigation-item component. This makes the styling for the subnav items to be more robust when wrapped with an other elements like an a tag

Test Steps

  • nx serve component
  • then open the localhost
  • finally test that visually nothing has changed

General Tests for Every PR

  • npm run start still works.
  • npm run lint passes.
  • npm run stylelint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.
Screenshots or link to StackBlitz/Plunker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant