Spilled data size in CLI and WebUI #426
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pnowojski I think we should remove the Driver and Pipeline level spill stats collecting and maintaining. They're not used anywhere. |
ilfrin
force-pushed
the
explain-analyze-spill
branch
from
38cc4d1
to
bc88476
Compare
pnowojski
approved these changes
Nov 17, 2016
| @@ -323,6 +331,11 @@ private static String formatFragment(Metadata metadata, Session session, PlanFra | |||
| return builder.toString(); | |||
| } | |||
|
|
|||
| private static boolean isNonZero(DataSize dataSize) | |||
| { | |||
| return dataSize != null && dataSize.getValue() != 0; | |||
There was a problem hiding this comment.
it can't, it was a reflex to implement a static helper method as null safe, I can change that if you want
ilfrin
force-pushed
the
explain-analyze-spill
branch
from
bc88476
to
8a47a00
Compare
added 3 commits
November 17, 2016 15:49
Add tracking of spilled data size on various levels (from operator to query) and expose it in JSON.
Data size added to EXPLAIN ANALYZE output, at Fragment and Operator levels. This information is added to the "Cost" line and displayed only if the value is non-zero.
When CLI is started with --debug then spilled data size for the entire query is being displayed (both in the running total, and the final summary). The information is added in a separate line below "Parallelism".
ilfrin
force-pushed
the
explain-analyze-spill
branch
from
8a47a00
to
c6747df
Compare
|
@ilfrin for completeness, let's print total data spilled in the Presto UI on the query details page under Resource Utilization Summary (next to the CPU & Memory usage) |
|
lgtm |
Added spilled data size to the Query Details page in the Resource Utilization Summary section and to the Live Plan page in the Web UI just below the "Splits" line (per stage).
ilfrin
force-pushed
the
explain-analyze-spill
branch
from
c6747df
to
7c1d6d5
Compare
|
@KBP-TDC done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pnowojski @sopel39