Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added nosql and dynamo plugins #429

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added nosql and dynamo plugins #429

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 17, 2016

added nosql counterpart to base-jdbc submodule
added dynamodb plugin

<version>3.4</version>
</dependency>

<!-- for testing -->

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessary comment.

import static java.util.Objects.requireNonNull;

/**
* Created by amehta on 6/13/16.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove that.

import java.util.Properties;

/**
* Created by amehta on 6/13/16.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@maciejgrzybek
Copy link

Seems like there are some code style failures. Can you reformat the code using code style defined in https://github.com/airlift/codestyle ?

@akshatnair
Copy link

Please add Apache license header on all the new files

@cawallin
Copy link

@sclinebacker84 -- our apologies for not getting back to you sooner, but if you want to get this PR into upstream master (prestodb/presto), please submit a pull request there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants