Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(tutorial): made a tutorial for unity developer a better understan… #79

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

Imitater967
Copy link
Contributor

Added tutorial for unity developer better unstanding of DAG

Copy link

@BenjaminAmos BenjaminAmos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks mostly good, although I have some thoughts about particular wording and requests for clarification.

Additional graphics documentation has been sorely needed. Thanks!

docs/tutorial-for-unity.md Outdated Show resolved Hide resolved
docs/tutorial-for-unity.md Outdated Show resolved Hide resolved
Comment on lines 9 to 11
You can regard a node as a "Render Pass" or simply a "Render Feature" in Unity.
A pass is a rendering stage, a render feature is a customized code you can do in during a stage.
So a Terasology node is more like a "Render Feature" in Unity.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a "Render Pass" or a "Render Feature" then? This paragraph is a bit confusing. Are you trying to suggest that a node actually performs aspects of both things?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, my misteake, a render feature already included render pass, render feature is like a wrapper for pass. sorry.

A pass is a rendering stage, a render feature is a customized code you can do in during a stage.
So a Terasology node is more like a "Render Feature" in Unity.

Image, there is not rendering stage concept, event the rendering stage itself is a rendering feature.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There appear to be a few typos here. Did you mean this?

Suggested change
Image, there is not rendering stage concept, event the rendering stage itself is a rendering feature.
Imagine that there is no rendering stage concept. That even the rendering stage itself is a rendering feature.

docs/tutorial-for-unity.md Outdated Show resolved Hide resolved
docs/tutorial-for-unity.md Outdated Show resolved Hide resolved
docs/tutorial-for-unity.md Outdated Show resolved Hide resolved
docs/tutorial-for-unity.md Outdated Show resolved Hide resolved
docs/tutorial-for-unity.md Outdated Show resolved Hide resolved
docs/tutorial-for-unity.md Outdated Show resolved Hide resolved
docs/tutorial-for-unity.md Outdated Show resolved Hide resolved
docs/tutorial-for-unity.md Outdated Show resolved Hide resolved
docs/tutorial-for-unity.md Outdated Show resolved Hide resolved
docs/tutorial-for-unity.md Outdated Show resolved Hide resolved
docs/tutorial-for-unity.md Outdated Show resolved Hide resolved
docs/tutorial-for-unity.md Outdated Show resolved Hide resolved
docs/tutorial-for-unity.md Outdated Show resolved Hide resolved
docs/tutorial-for-unity.md Outdated Show resolved Hide resolved

## Common Issues

If you wrote a shader, but Terasology doesn't recognize it, you must remember to create a material.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cervator already asked about this: You mean that if Terasology doesn't recognize a shader I wrote, I probably forgot to create a material and have to create one, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Copy link
Member

@jdrueckert jdrueckert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some more minor typos and wording suggestions

docs/tutorial-for-unity.md Outdated Show resolved Hide resolved
docs/tutorial-for-unity.md Outdated Show resolved Hide resolved
docs/tutorial-for-unity.md Outdated Show resolved Hide resolved
Imitater967 and others added 4 commits April 8, 2024 00:05
Co-authored-by: jdrueckert <jd.rueckert@googlemail.com>
Co-authored-by: jdrueckert <jd.rueckert@googlemail.com>
Co-authored-by: jdrueckert <jd.rueckert@googlemail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants